search

dennisreimann / bitcoindevlist.com

Support bitcoin developers so they can focus on building our future.
https://bitcoindevlist.com
MIT License
79 stars 127 forks source link

Add vincenzopalazzo to donatees list #124

Closed vincenzopalazzo closed 2 years ago

vincenzopalazzo commented 2 years ago

Signed-off-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com

netlify[bot] commented 2 years ago

✔️ Deploy Preview for bitcoindevlist ready!

🔨 Explore the source changes: 93296094564783d097e821dbce6f316074dc8f79

🔍 Inspect the deploy log: https://app.netlify.com/sites/bitcoindevlist/deploys/61b759b354840f0007704b31

😎 Browse the preview: https://deploy-preview-124--bitcoindevlist.netlify.app

jsarenik commented 2 years ago

There are two commits with the same subject containing the same typo. Please fix that @vincenzopalazzo (squash and edit with git rebase -i).

vincenzopalazzo commented 2 years ago

Thanks, @jsarenik for the review, now the double commit should be fixed.

jsarenik commented 2 years ago

@vincenzopalazzo The commit subject still says "danation" instead of "donation".

vincenzopalazzo commented 2 years ago

@vincenzopalazzo The commit subject still says "danation" instead of "donation".

@jsarenik Oh it is my bad, thank you for your careful review. It is amazing

jsarenik commented 2 years ago

@vincenzopalazzo One more nit. Once the commit is merged the "Proposed ...[long sentence ended with dot follows]" part of the subject does not make sense. It is also good to check previous commits when people were adding themselves and stick to the culture of the repo. So please keep it simple:

Add vincenzopalazzo

PS: no dot in the end of line please, this is first line of a commit description, something like Subject in the email PPS: "donatee" means according to Wordnik "Someone who has received a donation or Someone who needs a donation." PPPS: Adding @vincenzopalazzo (with at, referring to a github nickname) is considered spam in other projects, so maybe just think about it for a while and take it as part of culture. In this case it would be of course self-directed SPAM :)

Thank you @vincenzopalazzo for showing me all this, I am considering adding myself just to encourage anyone else who still hesitated to add themselves here :-)

vincenzopalazzo commented 2 years ago

@jsarenik you should add yourself to this list, you make a great contribution to bitcoin-related projects.

PPPS: Adding @vincenzopalazzo (with at, referring to a github nickname) is considered spam in other projects, so maybe just think about it for a while and take it as part of culture. In this case it would be of course self-directed SPAM :)

I disagree with this, only because this is bad for accessibility, tools like GitHub highlights the GitHub name, and make life easier for people that have reading problems. Some cultures, need to be reviewed to give all the possibilities to have an easier life. But I'm just a coder, I care about the code accessibility, and for now, this change makes sense. Thanks :)