search

dennisreimann / bitcoindevlist.com

Support bitcoin developers so they can focus on building our future.
https://bitcoindevlist.com
MIT License
79 stars 127 forks source link

Update Sjors #137

Closed Sjors closed 2 years ago

Sjors commented 2 years ago

See 035da6e08db793eccf5d12f526c8b75f875a313f to compare commit signature.

I also have a Lightning Address now (sjors@bitrefill.me), but I'd rather not override my Github Sponsor link with that.

netlify[bot] commented 2 years ago

Deploy Preview for bitcoindevlist ready!

Name Link
Latest commit b45dd03b5dd61dede36cc4e03ae220a8d3786a48
Latest deploy log https://app.netlify.com/sites/bitcoindevlist/deploys/6273c7186898d10008ceba00
Deploy Preview https://deploy-preview-137--bitcoindevlist.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

dennisreimann commented 2 years ago

Hey Sjors, you can provide the Lightning Address separately, as lnaddr, see the available options.

Sjors commented 2 years ago

Added!

@dennisreimann should I also set "lightning": true in that case?

Sjors commented 2 years ago

Looking at the source code:

https://github.com/dennisreimann/bitcoindevlist.com/blob/4ed462fbe972765df80f3f3ada4dfa86ecde6878/includes/mixins.pug#L30-L45

I should probably keep "lightning": false, because the icon would appear next to the Github link.

Instead, maybe we should add a lightning icon next to the Bolt 12 and lightning address?

Sjors commented 2 years ago

@dennisreimann thanks! Note that if you squash the commit, rather than using a merge commit, you lose my commit PGP signature. Which in turn makes it more difficult for people to verify the bolt12 URL and lightning address belongs to me.

dennisreimann commented 2 years ago

Thanks for the heads-up, I'll change the default setting for pr merges.