search

dennisreimann / ioctocat

iOctocat v1 - GitHub for iOS (works on the iPhone, iPad, and iPod Touch)
http://ioctocat.com/
1.65k stars 256 forks source link

Passcode option for app #302

Closed zeorze closed 11 years ago

zeorze commented 11 years ago

Would it be possible to add a passcode option to the app similar to what the Dropbox app has?

ruddfawcett commented 11 years ago

A better option would be to have a setting to not save GitHub password?

iosdeveloper commented 11 years ago

I suggest not to persist the OAuth token and instead ask for a password on every sign in. Could be implemented as a switch in the add/edit account controller.

zeorze commented 11 years ago

That would also be a solution that would work for me.

I have several private repositories in my account and therefore would like another layer of protection when viewing the app. Yes my devices already have pincodes but I see the code stored within these private repositories as valuable as what might be stored in Dropbox.

In fact with the Dropbox app you can set it to also remove any data associated with the app on the device after 10 failed passcode attempts.

Just being paranoid that's all.

ruddfawcett commented 11 years ago

@iosdeveloper better for settings.bundle?

dennisreimann commented 11 years ago

I'm closing this for now, feel free to reopen it, if someone would like to implement it or also thinks this is necessary.