search

dennisreimann / kindle-display

Kindle Status Display
https://d11n.net/kindle-status-display.html
MIT License
81 stars 26 forks source link

changed the visual representation of the battery level #8

Open csperle opened 4 years ago

csperle commented 4 years ago

Please take a look on this commit that changes the way the battery level is shown. The problem with the old indicator was, that it should show the battery level (if < 25) as a number in percent. The problem: the kindle 4 can not show the percent sign. This looked strange. See for more details:

https://www.mobileread.com/forums/showthread.php?t=278982

I wanted to change that into a visual representation drawing two rectangles on the screen, showing how full the battery is. Unfortunatelly also this command does not work on a kindle 4 (argh!). See:

https://wiki.mobileread.com/wiki/Eips

Now I am using characters showing a somewhat visual representation (enriched with the number):

|----25->==|

Only pull it, if you like it.

Because I only want to call the drawing command once, I used this odd looking switch-case structure instead of a fancy loop to generate the characters.

dennisreimann commented 4 years ago

To be honest I don't want to overcomplicate this part. I'm running the Kindle plugged in all the time, because my battery is too weak to run it for two days straight and other peoples experience seems to be along the same line.

csperle commented 4 years ago

Good point. I have enhanced the feature to only show the battery level if not plugged in.

But no worries for not pulling. I can rebase the feature when the development moves on to still show it on my kindle:)

dennisreimann commented 4 years ago

I'll leave this open for others to maybe chime in – but as you said, it's easy to apply this on a personal basis.