dennisreimann
commented
5 years ago Hey Matteo, thanks for the additions and also the kind words :)
How about we call the canonical field themeIds and make it backwards compatible by populating it when theme is set? Iād also like it, because it explicitely states the fact that we are expecting id values here.
We also have to change this for the tokens of a page, they should work just the same.
Once that is done, the commits should be squashed and use an emoji of your liking š
therealpecus
allcontributors[bot]
The option to restrict variant display to a given theme id was added in 2.1.0 following an issue from one of our devs. We are currently working on a DS with 3 themes: this PR is a progressive enhancement on the 2.1.0 release (the old syntax still works) allowing to address more than one theme in the
themeoption. Semantic suggests the property should be called themes but this would break compatibility or add two config options achieving the same goal.Documentation is updated. Let me know if the commits should be squashed or if there are any issues with coding style (changes are minimal).
This project is really well done and it's a pleasure to contribute to it. Awesome job Dennis, it's a great tool!
Best, Matteo