search

dennisreimann / uiengine

Workbench for UI-driven development
https://uiengine.uix.space/
MIT License
366 stars 25 forks source link

Local sample server JS crashes on load - r.index is undefined #53

Closed Flixbox closed 5 years ago

Flixbox commented 5 years ago

Describe the bug Accessing localhost:3000 gives the error r.index is undefined. The UI admin page (Port 3001) works perfectly.

To Reproduce Follow the steps in the example setup process up to npx uiengine build --serve --watch.

Expected behavior I can see a rendered page.

Screenshots image image

dennisreimann commented 5 years ago

Are you running on Windows? For me it works (testing on a Mac) – can you provide a repo I can reproduce it with?

Flixbox commented 5 years ago

Yes, I am running on Windows. I can provide you with a repo, hold on a minute or two.

Flixbox commented 5 years ago

Here we go:

https://github.com/Flixbox/uiengine-bug-reproduction

dennisreimann commented 5 years ago

Ok, I'm not able to really test it on Windows and Travis-CI does not fully support the Windows builds, yet. Hence stuff gets broken from time to time – mostly related to the different file system path formats.

Would you be willing to help fix this or did you just want to quickly check out the project? I'm sorry that it's broken though, I can take a look next week maybe.

Flixbox commented 5 years ago

The project was recommended to me by a coworker and I'm looking at it as an alternative to react-styleguidist for documenting my react projects.

What would be required to fix this? It'd already be helpful to get a few sourcemaps to see where the error lies. Maybe it's a simple fix, I'd be willing to help with that :)

dennisreimann commented 5 years ago

I can reproduce this using a virtual machine and I'll take a closer look during the next days. Sorry for the inconvenience!

dennisreimann commented 5 years ago

Alright, for me it now works on Windows with the just released v2.5.7 – let me know if this also works for you :)

The test are now also working on Windows, though there are still some minor failures on Travis which I'll fix soon.

Flixbox commented 5 years ago

Awesome work, thank you! I'll make sure to try it tomorrow and give you some feedback.

dennisreimann commented 5 years ago

The tests now also pass on Travis, nevertheless the build step still fails due to a problem in Travis. The windows build allows failures for now so that hopefully general errors on Windows will surface on my radar earlier now :)

Flixbox commented 5 years ago

Yup, I'm getting zero errors on my windows machine and the page renders wonderfully. Thank you!

dennisreimann commented 5 years ago

Alright, thanks for reporting this issue!

Let me know how the UIengine works for you and in case you have ideas for improving it :)