Closed therealpecus closed 4 years ago
I hit resolve thinking I could comment... I'll push the changes and resolve it later
Thank you very much! I will take a closer look soon :)
Hey @therealpecus, I reviewed this and found a few things that needed minor tweakings, which I did in bdb47bf33dfd922c6a526c94d1e1d685276e5c4e.
Can you have a look at the changes and cherry-pick the commit to be included in this PR?
In particular:
ContentCode
component in the MainTemplate
view also needed the path prefix/postfix.Thanks for taking care of this, I really appreciate it!
I now also rebase the branch with the current master βΒ is it good to go from your perspective?
Sorry @dennisreimann I did not have time to look back into it. At a glance I'd say all is good, and thanks for the finishing touches. I might not find a break to give proper time to this before next week π
No hurry :)
Rebased and merged manually, see a39849b0d63060a5f056086400b1a89c266aa1a0.
Thanks again @therealpecus!
Describe the changes Fixes #43 This PR restores the HTML code panel. The rendered HTML is sourced by fetching the document displayed in the preview iframe. It runs at render time of the component instance, and the slight delay between the component setup and content display is handled by a loading state (localized).
A new config option (
componentCommentDelimiter
) has been added to avoid outputting conditional comment blocks around the rendered template:<!-- uiengine:preview:start --> ... <!-- uiengine:preview:end -->
. It defaults to true. Setting this flag to false would not output the comment tags in the rendered html; the HTML code panel would show the full HTML document.This last contribution can be removed if out of scope for this feature, but since I had already coded it I left it as a topic to discuss during the code review.
π Household chores missing: commits should be squashed before merge.
Steps to check the contribution
yarn build
yarn run test-project
Checks to pass [x] Linting still works [x] Unit tests are passing [x] Acceptance tests are passing [x] Commit messages start with a somehow fitting emoji