dennisreimann / uiengine

Workbench for UI-driven development
https://uiengine.uix.space/
MIT License
366 stars 25 forks source link

💄UI: Update default neutral colors and accent colors. #75

Closed CosAnca closed 4 years ago

CosAnca commented 4 years ago
dennisreimann commented 4 years ago

I know this might just be a start, but I'm not convinced with the choice of colors – or at least the way the UI looks with them applied. Especially the sidebar does not look good and the structure get's lost as the general light background does not work with the dark bg of the sublevels.

colors
CosAnca commented 4 years ago

Oh, totally. My initial thinking was I would just update the neutral and accent color palettes here and then update the navigation style in a later PR related to #63 but now I realise it makes more sense to update the colors throughout the entire application in a single PR so we don't get this kind of issues. I'll update this PR with more color changes.

dennisreimann commented 4 years ago

Yeah, go ahead. You don‘t need to be too fine grained – something like 4-6 PRs for everything you proposed might suffice. Just wanted to ensure that it‘s not one big bang of changes (that‘s also hard to review). As long as it‘s a coherent chunk and not 5k lines changed you are good to go 😉

CosAnca commented 4 years ago

I made some more changes to the styles of the "application shell" and updated this PR with a couple commits. Basically now the topbar and the navigation sidebar should look very much like in the proposal (except it doesn't include the new font change which is addressed in PR #76 )

dennisreimann commented 4 years ago

Awesome, good work! 👍