Closed CosAnca closed 4 years ago
This PR addresses issue #59, #61, #69, #74 and partially #68. The last mentioned issue is partially addressed because I couldn't actually make it work even though I tried in a few different ways, so I may need some help to finish off this one.
Basically what I was trying to do was to bring in the proposed grid layout style for icons tokens but as an optional layout to not disrupt existing projects that may be using and really needing the table style.
This new grid layout should be rendered based on a property layout: grid
placed on the same object as type: 'category'
and should only be available for type: 'icon'
tokens (see TODO on line 306 inside src/templates/tokens.ejs
). I've created a variable hasGridLayout
(line 14) and tried to wrap the code block right after the TODO in an else if
statement but didn't seem to work and I couldn't really figure out what was wrong. I may be missing something obvious but would really appreciate some help on this one.
I'll take a look at the icon grid layout :)
Rebased and merged manually, the icon grid layout works now and is also the default. I switched it to make table
an option (also added it to the docs), because the new display style is superior and should be the default. Thanks again, good work! 👍