🔀 fix concurrency issue when using plugin

dennisreimann / uiengine

Workbench for UI-driven development

https://uiengine.uix.space/

MIT License

366 stars 25 forks source link

🔀 fix concurrency issue when using plugin #84

Closed JNPLZ closed 4 years ago

JNPLZ commented 4 years ago

After updating the uiengine in our project, we ran into a concurrency issue during the build process when using a plugin. The output:

Error: EEXIST: file already exists, mkdir '[PROJECT ROOT]/dist'
    at Object.setup ([PROJECT ROOT]/node_modules/@uiengine/core/node_modules/@uiengine/ui/src/index.js:71:11)

The issue can be fixed for us by using the the synchronous copy function from fs-extra in file.js.

@naltatis 👀

naltatis commented 4 years ago

Not quite sure why node throws this EEXIST error but it seems to be a concurrency issue that happens while copying the plugin assets to the destination folder. This PR fixes the issue by using synchronous copy. @dennisreimann Do you need more input on this?

dennisreimann commented 4 years ago

Thanks for fixing. Released as v3.1.3

naltatis commented 4 years ago

Thanks for merging 🌻