search

dennisroche / xunit.ioc.autofac

XUnit2 Test Framework implementation with Autofac
MIT License
20 stars 9 forks source link

'System.Runtime' which was not found in the GAC. #5

Closed pizycki closed 7 years ago

pizycki commented 8 years ago 
Severity Code Description Project File Line Suppression State
Error Failed to add reference. The package 'xunit2.ioc.autofac' tried to add a framework reference to 'System.Runtime' which was not found in the GAC. This is possibly a bug in the package. Please contact the package owners for assistance.

Repro steps:

  1. create new library project (.NET 4.6)
  2. install xunit @ 2.2 beta build 3300
  3. install xunit2.ioc.autofac
dennisroche commented 8 years ago

@pizycki could you attach the new library project so that I can debug further?

Initial step to figure this out will be to download the lib and include the as a local project reference.

pizycki commented 8 years ago

There you go IzzyDev.Integro.zip

RavindraBarapatre commented 8 years ago

I am also getting same error.

dennisroche commented 8 years ago

I'm seeing a different error when trying to install the lib package. 

Unable to find a version of 'Autofac' that is compatible with 'xunit2.ioc.autofac 1.0.2 constraint: Autofac (>= 4.1.1)'.

I'll continue to investigate.

pizycki commented 8 years ago

Well, I haven't installed Autofac on this project. I did it now, but nothing have changed, the problem persists.

gitfool commented 7 years ago

I'm hitting this as well. Any chance the proposed fix can be merged soon?

dennisroche commented 7 years ago

Apologies. I didn't know there was a PR up. I'll review it now.

dennisroche commented 7 years ago

@gitfool fix is merged and nuget package is deployed. thanks @pizycki. glad that i setup a build/deploy early on.

gitfool commented 7 years ago

Gotta love Cake. Cheers! 🍰

gitfool commented 7 years ago

@dennisroche Except that didn't make any difference. Still getting the error trying to install 1.0.3!?

dennisroche commented 7 years ago

@gitfool bugger. i took the fix assuming that it worked for @pizycki.

gitfool commented 7 years ago

Yeah I assumed the same. The link in the PR implied it was enough. Are you able to repro with a new project targeting .NET FW 4.6.1 using the latest Autofac and xUnit prerelease?

dennisroche commented 7 years ago

I think I see the error with that PR - the System.Runtime needs to be added a dependency. I thought it was odd when I merged, however didn't have time to verify.

pizycki commented 7 years ago

Weird, it worked for me. Yet, I'm .net core newbie, so I could did something wrong. Waiting for PR from @dennisroche to be accepted.

PS: 🍰 is great !

dennisroche commented 7 years ago

:cake: all things. 👍

I merge the PR and deploy the 1.0.4 package. Usually would want to use pre-release tag however don't think many people are using this lib at the moment.

dennisroche commented 7 years ago

@pizycki the System.Runtime piece you added in needed to be listed as a dependency, outside that it would have been ignored. I think. Let's try. PR is merged.

gitfool commented 7 years ago

I don't see 1.0.4. Should it be available now?

dennisroche commented 7 years ago

I forgot to tag the build to generate the correct release number. It should be available now...

gitfool commented 7 years ago

I can install the package! 😉

dennisroche commented 7 years ago

:+1: great :)