search

dennisschroer / dsTitles

Titles bukkit plugin for minecraft.
3 stars 3 forks source link

1.8 Apache Maven Update #3

Closed DrkMatr1984 closed 9 years ago

DrkMatr1984 commented 9 years ago

Hi Dennis! I have recently began to run your plugin on my server and have updated the contents of your repo to 1.8. I made no code changes, I simply mavenized the project and added the 1.8 dependencies and their repos to the pom I created for the project.

I'm not sure if you use maven or approve of it, you're welcome to deny this pull request if you don't like Maven.

Thanks! DrkMatr1984

dennisschroer commented 9 years ago

Hi,

I can only welcome the usage of Maven :). By the time I created this plugin, I didn't know of Maven, but now that I've worked with it, I think it is a perfect way to handle dependencies and build configurations.

Thanks!

P.S. I haven't done MC plugins for a long time, so I dont know if all my plugins still work in the latest versions. Maybe I'll review them soon, mavenizing and testing them.

DrkMatr1984 commented 9 years ago

Well, I know for sure this plugin works with Spigot 1.8. I have been using it and have found no problems so far. (Actually, now that I think about it, I did get an NPE once I think I'll investigate if it pops up.) I can give a test with 1.8.3 and update the maven dependencies to 1.8.3 when I get a chance.