search

dennisschroer / dsTitles

Titles bukkit plugin for minecraft.
3 stars 3 forks source link

Expose Methods so other Plugins can hook #4

Open DrkMatr1984 opened 9 years ago

DrkMatr1984 commented 9 years ago

into dsTitles to retrieve data for Chat PlaceHolders(ie. DeluxeChat), add getChatTag method, bump to 1.5 in Plugin.yml(Shouldv'e done this already)

dennisschroer commented 8 years ago

Wow I never noticed this PR untill now, so sorry for not responding :P. Is this PR still relevant?

DrkMatr1984 commented 8 years ago

Yup, I'm running it currently on my 1.9 server. I did see the issue that other guy posted... I guess they changed the getOnlinePlayers() method in 1.9. I didn't get around to updating that yet, but it seems to function correctly on my server. I'd take the PR and merge and try to see if you can fix that, or I'll get around to it sooner or later.

DrkMatr1984 commented 8 years ago

I just realized the way I have it, you'll need DeluxeChat, a spigot premium resource, to compile it. As long as you don't redistribute it, I can give you a copy for development purposes. Grab it from https://www.dropbox.com/s/baddtuzg1gf7qnd/Dependencies.zip?dl=0

DrkMatr1984 commented 8 years ago

Yup, I'm running it currently on my 1.9 server. I did see the issue that other guy posted... I guess they changed the getOnlinePlayers() method in 1.9. I didn't get around to updating that yet, but it seems to function correctly on my server. I'd take the PR and merge and try to see if you can fix that, or I'll get around to it sooner or later.

Yep, this is fixed. As well as a few other bugs. I believe it would even be backwards compatible to pretty far back.

DrkMatr1984 commented 3 years ago

A lot more fixes aded now, if you still want to merge the pull request.

DrkMatr1984 commented 2 years ago

To the Moon! 🚀