search

dennissergeev / atmosscibot

Twitter bot that generates word clouds of new open access publications in atmospheric sciences.
https://twitter.com/AtmosSciBot
MIT License
10 stars 0 forks source link

Addition of PNAS Early Release Article RSS feed in journal_list.json #10

Closed patternizer closed 3 years ago

patternizer commented 4 years ago

PNAS Subs Dept PNASSubsDept@nas.edu | PNAS Subs Dept PNASSubsDept@nas.edu | Fri, 31 Jan, 18:50 (3 days ago)

Thank you for your message. Yes, you may add PNAS to your list. Please refer to https://www.pnas.org/page/about/rss for all available RSS feeds.

Sincerely,

Kay McLaughlin PNAS Subscriptions

PNAS Subs Dept PNASSubsDept@nas.edu

dennissergeev commented 4 years ago

Hi @patternizer!

Thanks for the PR!

There are a few important things to address before I can merge it though.

  1. The bot doesn't inherently know how to parse HTML pages, so a rule for PNAS needs to be added to parse_article.py. Namely, what HTML elements contain the text of the article. For example, for Wiley journals, the bot finds elements defined by this dictionary. It would be great if you could inspect the web page with the full text of your paper and add the rule accordingly.

  2. Does PNAS actually have open-access articles? (The bot cannot access the text otherwise.)

  3. If it does, this PR should also include a condition to only process articles related to atmospheric sciences (since this is AtmosSciBot). Is such information available from the RSS feed?