search

dennissergeev / pmctrack

Polar mesoscale cyclone (PMC) tracking algorithm
MIT License
3 stars 3 forks source link

Question about cf_synop_check.f90? #29

Open pst019 opened 4 years ago

pst019 commented 4 years ago

L95 in cf_synop_check.f90 are as follows:

  if (d_cf >= d_cf_min * rkilo) then
    if (lon(i_n) > lon(i_s) .and. theta_d_cf <= pi_thirds) then
      call quadric_fit(one(1:one_num, 1:2), one_num, a, b, c, k, r2)

      if(r2 >= 0.8 .and. k <= 0.1) then
        mtype_part=1
      endif

    elseif (theta_d_cf <= pi_ninths) then
      call quadric_fit(one(1:one_num, 1:2), one_num, a, b, c, k, r2)

      if(r2 >= 0.8 .and. k<= 0.1) then
        mtype_part=1
      endif
    endif
  endif

It seems like the routine checks if the angle, theta_d_cf, is positive and below 60 degree. if this is not the case the routine checks if the angle is below 20 degree.

Is this routine detecting angles between -20 and 60 degree? Shouldn't it satisfy two (both) conditions instead of "elseif"?

dennissergeev commented 4 years ago

Good question. I'll check the code and give you an update. Thanks for reporting this.