search

dennisss / tansa

Dancing Robotics Platform
MIT License
39 stars 16 forks source link

Review code and check for bugs #102

Closed tessmichi closed 7 years ago

tessmichi commented 7 years ago

Must be done before Friday so that on Saturday we can focus just on hardware on NYC.

tessmichi commented 7 years ago

Taking myself off of this because I added #105 and #106 and must implement those in this time

abramowitzK commented 7 years ago

Going through this today (11/25). Gonna be bulletproofing code

abramowitzK commented 7 years ago

https://github.com/svn2github/valgrind-vex/commit/1ab61656f71e94ce12b68de87f1e28cf3dc0c18c Here's a patch that may help us with valgrind. There's a typo that makes using RDRAND instructions (used by c++ std RNG) not work under valgrind. Will recompile valgrind and see if this fixes it

abramowitzK commented 7 years ago

Compiling the latest valgrind from source includes this patch and does work with our code. Valgrind shows a lot of leaks, but most of them are inside libgazebo so it seems like they're not doing the greatest job of cleaning up. Don't think most of them are a problem. I'll keep whittling away at this. Will take a while.

tessmichi commented 7 years ago

Awesome thanks :) Can you please give us the command you're using so we can start running it with every PR?

tessmichi commented 7 years ago

(updating due date since "Production - 1" is this upcoming Tuesday so I can't really push the Thanksgiving due date any farther)