search

dennisss / tansa

Dancing Robotics Platform
MIT License
39 stars 16 forks source link

Some breakpoints not working #145

Closed dennisss closed 7 years ago

dennisss commented 7 years ago

I've added breakpoints to singleDrone (https://github.com/dennisss/tansa/blob/newer/data/singleDrone.jocs) to verify that they work.

It seems like the 'square-3' breakpoint doesn't work even though there is a line that starts at the time.

@abramowitzK I think you were last to work on breakpoints

abramowitzK commented 7 years ago

@dennisss Didn't change anything with breakpoints on master so unsure why it's not working. I believe @zls29 and @tessmichi wrote the code for breakpoints.

dennisss commented 7 years ago

Ok. Nevermind, i've found the issue

abramowitzK commented 7 years ago

Now you can't start from the beginning, it always starts from the first breakpoint (wherever that may be). Need to investigate this issue further.

dennisss commented 7 years ago

Hmm. It sounds like a GUI issue as the select dropdown always defaults to the first breakpoint in the list without a default option?

Quick fix would be to only use files with a breakpoint at the very beginning

dennisss commented 7 years ago

Confirmed: loading from console with startPoint -1 properly loads from the beginning. So I think the GUI needs an extra default option

dmz38 commented 7 years ago

@dennisss can you provide an example file that does this? Thanks!

dennisss commented 7 years ago

@dmz38 , take singleDrone.jocs in master and remove the first breakpoint, then there will be two other remaining breakpoints not starting at time = 0

dmz38 commented 7 years ago

Ah OK. Couldn't the solution be in the CPP that if the first entry in JOCS (or CSV in the new system) doesn't set a breakpoint, then we should make one by default?

dennisss commented 7 years ago

Yeah, we could add a breakpoint into the list if none is at time=0 or add an option in the GUI for

dennisss commented 7 years ago

Added a patch in my branch when using the viewer