CSV Lighting Specification

dennisss / tansa

Dancing Robotics Platform

MIT License

39 stars 16 forks source link

CSV Lighting Specification #150

Closed dennisss closed 7 years ago

dennisss commented 7 years ago

Mike asked about how to specify lighting yesterday, although there currently isn't a way?
The simulation viewer is setup to show RGB lights now so this should be easily testable

abramowitzK commented 7 years ago

I'll implement lighting today in CSV. I just need to fill in the parsing functions

abramowitzK commented 7 years ago

Currently working on this in csv branch

abramowitzK commented 7 years ago

@dennisss The lights only have RGB channels and no overall intensity values correct? or are they RGBA?

EDIT: Found examples in code. Think I'm good for now.

abramowitzK commented 7 years ago

@dennisss Do you want me to adapt the currently existing lighting stuff (controller and trajectories) to be used exclusively with rgb drones or should I remain backwards compatible?

dennisss commented 7 years ago

Go ahead and change it. Preferably maintain backwards compatibility by just casting single channel values to white/gray, no need to be too fancy

abramowitzK commented 7 years ago

Will do. I've got white_strobe and white_light in csv already for old functionality. Will let you know when I'm done so you can review and suggest any changes.

abramowitzK commented 7 years ago

Probably wont' be done til friday though. Have to catch up on grading. Depends on how late I stay up...

abramowitzK commented 7 years ago

Talked to mike about lighting specification. He is used to composing lighting effects together (Strobe+Fade+Color for example). This is apparently how they do it in the theater world. Working on a good way to replicate this

abramowitzK commented 7 years ago

This is partially implemented in csv_lighting branch. In progress.

abramowitzK commented 7 years ago

Lighting specification implemented in csv and parser