search

dennisv / django-storage-swift

OpenStack Swift storage backend for Django
MIT License
86 stars 60 forks source link

Do we really need AUTO_BASE_URL? #66

Closed einarf closed 7 years ago

einarf commented 7 years ago

While writing tests I found some problems with how AUTO_BASE_URL and SWIFT_BASE_URL interact.

If AUTO_BASE_URL is True we will end up completely ignoring the SWIFT_BASE_URL anyway, so I suggest dropping AUTO_BASE_URL and do the auto resolving if SWIFT_BASE_URL is not defined. Right now you have to manually disable AUTO_BASE_URL if you are overriding the base url.

Am I missing something important details here? If am right this would at least make configuration a lot more user friendly.

einarf commented 7 years ago

https://github.com/blacktorn/django-storage-swift/blob/master/swift/storage.py#L185-L204

einarf commented 7 years ago

Manage to write a proper test for it now. It makes sense.