search

dennisv / django-storage-swift

OpenStack Swift storage backend for Django
MIT License
86 stars 60 forks source link

Use swiftclient.Connection to handle operation retries natively #93

Closed leo-naeka closed 6 years ago

leo-naeka commented 6 years ago

This PR replaces regular swift methods by the swiftclient.Connection class that natively handles retries after any upload failure.

codecov-io commented 6 years ago

Codecov Report

Merging #93 into master will decrease coverage by 0.08%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   97.84%   97.75%   -0.09%     
==========================================
  Files           1        1              
  Lines         232      223       -9     
==========================================
- Hits          227      218       -9     
  Misses          5        5
Impacted Files Coverage Δ
swift/storage.py 97.75% <100%> (-0.09%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 07084b8...a8125c2. Read the comment docs.

einarf commented 6 years ago

Nice one. I've been having this change in the back of my head for a long time. Also making sure the backend re-authenticates if the token expires.