search

denny / ShinyCMS-ruby

ShinyCMS is an open-source CMS built in Ruby on Rails, with support for themes, plugins, and cloud hosting. (There is also a Perl version: www.github.com/denny/ShinyCMS)
https://shinycms.org
GNU General Public License v2.0
33 stars 11 forks source link

Mailers need separate tests #627

Open denny opened 4 years ago

denny commented 4 years ago

Currently most of the mailer code is only 'tested' indirectly, when the request specs touch a controller action that touches a model method that touches the mailer.

denny commented 3 years ago

If you are a less experienced developer who is looking at this issue and thinking you'd like to try to take it on but you're not entirely confident, I would be happy to help you - whether that's help getting set up, more explanation of what needs doing, pairing on the code task itself, or anything else I can do to help.

In my day job I'm a lead developer who often mentors less experienced developers, and I'd love to use some of that experience to help people take their first steps into contributing to open source projects.

denny commented 3 years ago

I just added basic mailer tests for ShinyForms[1] while I was fixing another issue in that plugin. DiscussionMailer and EmailRecipientMailer in the main app already have tests.

That leaves the following mailers still in need of separate tests:

[1] https://github.com/denny/ShinyCMS-ruby/blob/main/plugins/ShinyForms/spec/mailers/shiny_forms/form_mailer_spec.rb