search

denny / ShinyCMS

ShinyCMS is an open source CMS. This is the Perl version, built with Catalyst and DBIC. (There is also a Ruby on Rails version: www.github.com/denny/ShinyCMS-ruby)
58 stars 24 forks source link

fix schema.sql timestamp default value issue #11

Closed alaboszhang closed 8 years ago

alaboszhang commented 11 years ago

mysql timestamp default value can't be '1970-01-01', I't need start form 1971.

Thanks!

denny commented 11 years ago

Hi,

Thank you for the report and the suggested patch.

I'm going to reject this pull request, for two reasons:

  1. It's really noisy - you've made a lot of whitespace changes that don't actually change anything, but make the patch confusingly much bigger than it needs to be.
  2. I'll make a different change. I'm not actually sure why I used a default date at all, it looks like some sort of hideous kludge, so I'll work out a better approach instead - probably allowing null dates for this column, or something similar.

Thank you again for calling it to my attention though, and taking the time to submit a patch.

Regards, Denny