search

denny / ShinyCMS

ShinyCMS is an open source CMS. This is the Perl version, built with Catalyst and DBIC. (There is also a Ruby on Rails version: www.github.com/denny/ShinyCMS-ruby)
58 stars 24 forks source link

Events, Need Event Location Map Instead Of Just Zip Code (Post Code) #38

Closed wbraswell closed 9 years ago

wbraswell commented 10 years ago

It's kinda useless to have a Google maps link to a zipcode only, we need to be able to have a Google maps link which leads to the actual location of the event.

I was already able to enable this feature for User accounts, but only because there was a valid "user.location" data value available. I tried to short-cut this solution by storing a full address value in the postcode field, but I got the "come back later" error screen with an error logged:

stderr: [error] DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Data too long for column 'postcode'

denny commented 10 years ago

Ah yes, sorry - cultural difference there. In the UK, a postcode is quite specific - it links to a specific street, or even a subdivision of a street if it's a long street. I'd not considered how huge US zipcodes are in comparison!

Having the full address for an event would obviously be useful anyway, not sure why I didn't include that in the first place... I'll add it shortly. :)

denny commented 9 years ago

Done.

wbraswell commented 9 years ago

It works, but now postcode is just redundant and will give you a map with double postcodes if both address (with postcode) and stand-alone postcode fields are filled in. Will create an issue for this.

denny commented 9 years ago

I think I'll trust users to decide which data they want to put in which fields. If the US doesn't typically use the separate postcode field, that's fine - they can ignore it and everything will work okay.