search

denny / ShinyCMS

ShinyCMS is an open source CMS. This is the Perl version, built with Catalyst and DBIC. (There is also a Ruby on Rails version: www.github.com/denny/ShinyCMS-ruby)
56 stars 24 forks source link

Events, Need Remove Now-Redundant Zip Code (Post Code) #43

Closed wbraswell closed 9 years ago

wbraswell commented 9 years ago

This is related to a now-closed issue: https://github.com/denny/ShinyCMS/issues/38

Now that we have a working address field, the postcode field is just redundant. Because of this, there is a flaw with the new view_event.tt logic, whereby if you include BOTH an address (with postcode) and a stand-alone postcode, then you will be given a Google Maps link containing the postcode twice. Google Maps currently seems to allow this error, but it is definitely wrong and just because Google allows the wrong behavior now doesn't mean it will continue working in the future.

If you can't remove the postcode field because of legacy compatibility, then at least change the view_event.tt logic so that it never tries to concatenate the address and postcode fields; OR change the field label so that it says "Address Without Postcode (optional)" so people will never type in the postcode in the address field.

In America it is confusing to have both an "address" and "postcode" field, so the preferred solution is to totally remove the postcode field. After it is decided how to address this issue, then I will open a new issue to make the same change to the other places in Shiny where an address and/or postcode are utilized.

wbraswell commented 9 years ago

You can see how I've handled it in my own code here:

https://github.com/wbraswell/shacfleet.org/blob/master/modified/view_event.tt

You can see how it looks here:

http://shacfleet.org/events/2014/9/minto-rendezvous-2014

denny commented 9 years ago

I think I'll trust users to decide which data they want to put in which fields. If the US doesn't typically use the separate postcode field, that's fine - they can ignore it and everything will work okay.