denny / ShinyCMS

ShinyCMS is an open source CMS. This is the Perl version, built with Catalyst and DBIC. (There is also a Ruby on Rails version: www.github.com/denny/ShinyCMS-ruby)
56 stars 24 forks source link

Refactor discussion search #76

Closed denny closed 4 years ago

denny commented 4 years ago

Tidying up duplication of effort between the search() method for Discussions, and the build_url method it uses for redirects in the rest of its methods.

codecov[bot] commented 4 years ago

Codecov Report

Merging #76 into master will increase coverage by 0.02%. The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   87.49%   87.52%   +0.02%     
==========================================
  Files         111      111              
  Lines        5014     5001      -13     
  Branches      725      725              
==========================================
- Hits         4387     4377      -10     
+ Misses        362      357       -5     
- Partials      265      267       +2
Impacted Files Coverage Δ
lib/ShinyCMS/Controller/Discussion.pm 75.65% <75%> (-0.07%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 92ae353...c6384f1. Read the comment docs.