denobisipsis / adownloader

Automatically exported from code.google.com/p/atresdownloader
32 stars 16 forks source link

Caption issues - CBS #112

Open uckthis opened 5 years ago

uckthis commented 5 years ago

Hello again, Caption downloaded from CBS aren't properly formatted. Every caption has two "/N", which means an empty line between each subtitle. Also, for some reason ' is missing from these files, so I've, I'm, that's are saved as Ive, Im, thats, etc. Example: https://www.cbs.com/shows/the-late-show-with-stephen-colbert/video/K2wwM3Nwze8BdZGdv2lsLGrniwx4wIjp/the-late-show-10-31-18-mike-myers-christiane-amanpour-/

Could you add TLC, please?

Is it possible to see original caption file? The one we get is a converted .ass file, but is it possible to see the original file, be it .xml, .vtt, etc.? There are some files that lose some information when they're converted. For example, files converted from BBC captions lose the color code information. So if I could see the original file, I may be able to convert it myself and retain all the information.

Thank you for your amazing work.

denobisipsis commented 5 years ago

Hi,

update the program. The original captions file location is showed in log window, and now subtitleedit program is launched to edit the caps. You can change whatever you want but not name of file (subtemp.txt). Conversion is made by subtitleedit so i dont know if good or bad. Try to edit the caps to adjust them to what you want. If you want some specific change i can see how to implement it, even with pure code.

I'll see TLC.

uckthis commented 5 years ago

Hello, Everything seems to be in order now. The issue with CBS captions is in the original file, so there's nothing you or I can do about it. I'll email them. I'll post new threads if I came across a bug. Thank you.