search

denodrivers / mysql

MySQL driver for Deno
https://deno-mysql.netlify.com/
MIT License
260 stars 65 forks source link

Encryption test coverage #134

Closed MStefan99 closed 2 years ago

MStefan99 commented 2 years ago

While working on #132 I've noticed that all tests pass regardless of whether the data is actually encrypted properly in /src/auth_plugin/crypt.ts. The tests will pass even if the function returns same unencrypted data as it receives. I think it should be checked whether the plugin has the necessary test coverage.

lideming commented 2 years ago

Thank you for reminding. It's being tested and fixed in #142.