search

denoland / deno-astro-adapter

A Deno adapter for running Astro applications on the Deno runtime.
https://npm.im/@deno/astro-adapter
MIT License
79 stars 19 forks source link

Support for Astro @ 4.0? #10

Open joshgillies opened 11 months ago

joshgillies commented 11 months ago

There's been a recent major release of Astro https://astro.build/blog/astro-4/, and from the looks of things this adapter should work, however the peerDependency expects astro@^3.0.13 https://github.com/denoland/deno-astro-adapter/blob/main/package.json#L37.

jueewo commented 10 months ago

I'm having issues updating to Astro 4 as well, error message:

Could not resolve '#async_hooks' from 'file:///.../node_modules/.deno/astro@4.0.4/node_modules/p-limit/index.js'.

Hoping for an update of this adapter :-)

jose-donato commented 9 months ago

+1

Astisme commented 9 months ago

+1

jamesli2021 commented 9 months ago

Need fix for Astro 4.3.2 and beyond.

aaronlifton commented 9 months ago

Need a fix as well. Was hoping to deploy my astro site on deno deploy.

lajbel commented 8 months ago

+1

fro-profesional commented 8 months ago

I saw on discord, that currently the node build with unstable flags is working in deno

https://discord.com/channels/684898665143206084/1204542187199668235/1204547434324426792

toybreaker commented 8 months ago

@fro-profesional ok, but what is the point of using Deno if then i have to use an unstable flag build... nope, maybe i am to understand missing something?!

Looks like is not yet possible to consider using it atm… and its a pity, cos Astro is in the stack Deno is a maybe soon at this point, and i am sure i am not the only one

On 28 Feb 2024, at 06:38, Francisco Ramos @.***> wrote:

I saw on discord, that currently the node build with unstable flags is working in deno https://discord.com/channels/684898665143206084/1204542187199668235/1204547434324426792 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

treb0r commented 8 months ago

Is this adapter no longer maintained?

treb0r commented 8 months ago

Astro 4.5 dropped today 🚀🚀

jueewo commented 8 months ago

Astro is great 🚀🚀, but I gave up waiting for an update here. I assume it's not maintained anymore, Deno is even not mentioned on the Astro website (as far as I know this adapter was originally maintained by Astro, it seems it was took over by Deno and the development stopped).

toybreaker commented 8 months ago

And that is a real bummer, cos when forced to pick many will stick to Astro and drop Deno, like we had to do...

Maybe the Deno focus now is on monetise the SAAS, but loosing early adoptioers is not quite a smart move...

On Tue, Mar 12, 2024, 2:56 AM Jürgen Wöckl @.***> wrote:

Astro is great 🚀🚀, but I gave up waiting for an update here. I assume it's not maintained anymore, Deno is even not mentioned on the Astro website (as far as I know this adapter was originally maintained by Astro, it seems it was took over by Deno and the development stopped).

— Reply to this email directly, view it on GitHub https://github.com/denoland/deno-astro-adapter/issues/10#issuecomment-1989210830, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBJ3YKJ4UCKD3LKQWL3J4LYXX45BAVCNFSM6AAAAABAOIBBY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBZGIYTAOBTGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Ayfri commented 8 months ago

Any update ?

skrzepij commented 7 months ago

It looks like the problem has been solved, but an update to the npm registry has not yet been released. Temporarily, you can update package.json and install the adapter directly from the github repository - it helped in my case.

  "dependencies": {
    "@astrojs/deno": "github:denoland/deno-astro-adapter",
    "astro": "^4.5.9"
  }

So maybe the adapter will still be developed. Finger crossed 🤞🏻

kt3k commented 6 months ago

We changed the package name from @astrojs/deno to @deno/astro-adapter because of the change of the maintainers.

Now the latest version (v0.1.2) of @deno/astro-adapter should support astro 4.0.

khoipro commented 5 months ago

Please also update related document. https://docs.astro.build/en/guides/deploy/deno/

EdamAme-x commented 5 months ago

hmm... Errors no longer occur, but process.env is not loaded

EdamAme-x commented 5 months ago

my deps

{
  "name": "tmp",
  "type": "module",
  "version": "0.0.1",
  "scripts": {
    "dev": "deno run -A npm:astro dev",
    "start": "bun run dev",
    "build": "astro check && astro build",
    "preview": "deno run -A npm:astro preview",
    "astro": "astro",
    "format": "prettier --write ./**/*.{ts,astro}"
  },
  "dependencies": {
    "@astrojs/check": "^0.7.0",
    "@astrojs/react": "^3.4.0",
    "@astrojs/tailwind": "^5.1.0",
    "@deno/astro-adapter": "github:denoland/deno-astro-adapter",
    "@radix-ui/react-slot": "^1.0.2",
    "@types/react": "^18.3.3",
    "@types/react-dom": "^18.3.0",
    "astro": "^4.9.2",
    "astro-seo": "^0.8.4",
    "class-variance-authority": "^0.7.0",
    "clsx": "^2.1.1",
    "lucide-react": "^0.383.0",
    "prettier": "^3.3.0",
    "prettier-plugin-astro": "^0.14.0",
    "react": "^18.3.1",
    "react-dom": "^18.3.1",
    "tailwind-merge": "^2.3.0",
    "tailwindcss": "^3.4.3",
    "tailwindcss-animate": "^1.0.7",
    "typescript": "^5.4.5"
  },
  "prettier": {
    "tabWidth": 4,
    "useTabs": true,
    "singleQuote": false,
    "printWidth": 120,
    "bracketSameLine": false,
    "plugins": ["prettier-plugin-astro"],
    "overrides": [
      {
        "files": "*.astro",
        "options": {
          "parser": "astro"
        }
      }
    ]
  }
}
EdamAme-x commented 5 months ago

@kt3k do you have any idea?

EdamAme-x commented 5 months ago

hmm... Errors no longer occur, but process.env is not loaded

so my code throwing error.

EdamAme-x commented 5 months ago

additional info: in develop mode

EdamAme-x commented 5 months ago

DENO_FUTURE=1 resolved