search

denoland / deno-gfm

Server-side GitHub Flavored Markdown rendering for Deno
https://jsr.io/@deno/gfm
MIT License
221 stars 33 forks source link

test: add basic test #49

Closed hashrock closed 1 year ago

hashrock commented 1 year ago

Close #48

lino-levan commented 1 year ago

Also, in general, I think we probably want a better testing story for this. I think using puppeteer or something like that would be important to make sure the CSS renders correctly as well (one of the big issues with math rendering when I was making that PR was that font rendering did not work and I didn't realize).

lino-levan commented 1 year ago

I should clarify that I think (other than my comment), this PR LGTM. Just thinking about a future PR for more expansive tests given how often deno-gfm is used.

hashrock commented 1 year ago

Thank you! Yeah more extensive testing is needed. Let's make another issue to expand testing. For now, I've only built the foundation for this issue.