search

denoland / deno-gfm

Server-side GitHub Flavored Markdown rendering for Deno
https://jsr.io/@deno/gfm
MIT License
226 stars 37 forks source link

chore: add basic md table with dollar sign test #89

Closed deer closed 10 months ago

deer commented 10 months ago

closes https://github.com/denoland/deno-gfm/issues/65

@lionel-rowe @lino-levan, what do you think about this? I took the md from the issue and wrapped it with the boilerplate from the README.md file and everything is rendering correctly. Changing the spacing between the pipe and dollar sign had no effect.

So this PR is to just assert that the functionality works and won't break in the future.

deer commented 10 months ago

@hashrock, since you're so fast with reviewing these, what do you think about this one?

hashrock commented 10 months ago

Hmm, I'm not sure. The deps has been upgraded from marked@5.1.0 to marked@11.1.1 over the past few months, so it may have been fixed in the process.

Regardless, there's nothing more reliable than unit tests. If this issue still occurs, let's create another issue. Thank you for your contribution!

hashrock commented 10 months ago

Ugh, it failed in CI.

https://github.com/denoland/deno-gfm/actions/runs/7571288796/job/20618506624#step:7:89

deer commented 10 months ago

A soft-conflict with the previous PR. I'll open a fix soon.