denoland / deno

A modern runtime for JavaScript and TypeScript.
https://deno.com
MIT License
96.93k stars 5.35k forks source link

compat: tracking issue for running `find-up` test case #12999

Closed kt3k closed 2 years ago

kt3k commented 2 years ago

This issue is part of #12886

This issue tracks the remaining issue for running the test cases of find-up in node-compat mode.

ref #12577

bartlomieju commented 2 years ago

Getting inspector polyfilled will be a rather involved effort, as we don't have any runtime APIs exposing inspector functionalities. @kt3k could you check which APIs from that module are actually required?

kt3k commented 2 years ago

inspector is used in ava. ref: https://github.com/avajs/ava/blob/main/lib/cli.js#L119-L121

But if inspector.url() returns undefined, it seems that ava is not going to use the actual inspector features

bartlomieju commented 2 years ago

@kt3k maybe we could shim it for now and always return undefined?

kt3k commented 2 years ago

ava@latest seems needing ipc features (process.send(), process.on("message") ) to communicate with forked child_processes in which the actual test cases are running.. 😬

kt3k commented 2 years ago

IPC BoardcastChannel is not available yet https://github.com/denoland/deno/issues/10750

kt3k commented 2 years ago

find-up now seems working and I can run nps command in node compat mode without an issue. (I don't know what exactly fixed the issue, but the issue doesn't reproduce now). Closing

bartlomieju commented 2 years ago

ava@latest seems needing ipc features (process.send(), process.on("message") ) to communicate with forked child_processes in which the actual test cases are running.. 😬

Seems directly related to https://github.com/denoland/deno/issues/12879

kt3k commented 2 years ago

Yeah, exactly. Let's track on that issue

I feel IPC features are widely used in npm ecosystem. So I think we need somehow to support it until v0