denoland / deno

A modern runtime for JavaScript and TypeScript.
https://deno.com
MIT License
98.23k stars 5.41k forks source link

Panic While Running `deno compile` with `--no-check=remote` When Remote Type Checking Fails #14526

Closed zicklag closed 2 years ago

zicklag commented 2 years ago

I'm have a simple repo that includes a package from Skypack, but Skypack doesn't quite handle the Deno types for the buttercup library that I'm trying to import right.

Here's the repo: https://github.com/zicklag/buttercup-cli ( don't worry just a couple < 10 line typescript files )

I had to do a weird workaround when importing the library to get it to work, which isn't a Deno issue, but a Skypack issue.

But when I try to run deno compile, Deno panics:

➜ RUST_BACKTRACE=1 deno compile --no-check=remote mod.ts
Download https://cdn.skypack.dev/-/hot-patcher@v0.5.0-7EE3IEG9UpbPwFxl3fWR/dist=es2019,mode=types/index.d.ts
Download https://cdn.skypack.dev/error/stream?from=webdav
Check file:///home/zicklag/tmp/bdeno/mod.ts

============================================================
Deno has panicked. This is a bug in Deno. Please report this
at https://github.com/denoland/deno/issues/new.
If you can reliably reproduce this panic, include the
reproduction steps and re-run with the RUST_BACKTRACE=1 env
var set and include the backtrace in your report.

Platform: linux x86_64
Version: 1.21.2
Args: ["deno", "compile", "--no-check=remote", "mod.ts"]

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Missing(Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("cdn.skypack.dev")), port: None, path: "/-/hot-patcher@v0.5.0-7EE3IEG9UpbPwFxl3fWR/dist=es2019,mode=types/index.d.ts", query: None, fragment: None })', cli/main.rs:428:17
stack backtrace:
   0: rust_begin_unwind
             at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/panicking.rs:498:5
   1: core::panicking::panic_fmt
             at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:116:14
   2: core::result::unwrap_failed
             at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/result.rs:1690:5
   3: deno::compile_command::{{closure}}
   4: deno::main::{{closure}}
   5: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
   6: deno_runtime::tokio_util::run_basic
   7: deno::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

It might be worth noting that I see the error about the missing module every time I run deno run, but it doesn't halt execution if I run it with --no-check=remote:

➜ deno run -A --no-check=remote mod.ts
Download https://cdn.skypack.dev/-/hot-patcher@v0.5.0-7EE3IEG9UpbPwFxl3fWR/dist=es2019,mode=types/index.d.ts
Download https://cdn.skypack.dev/error/stream?from=webdav
stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.