kxxt
commented
1 year ago The errors from TypeScript LSP is perhaps caused by some path manipulation operations in 00_typescript.js.
In function pathForLibFile in 00_typescript.js:
function hexEncode(s) {
// helper function for debugging
let result = "";
for(let i=0; i < s.length; i++) {
let hex = s.charCodeAt(i).toString(16);
result += ("000" + hex).slice(-4);
}
return result;
}
function pathForLibFile(libFileName) {
const core = globalThis.Deno.core;
core.print(`entering pathForLibFile(${libFileName}): \n`);
const components = libFileName.split(".");
let path = components[1];
core.print(`!!!!! path = ${path}, components = ${components}\n`, true);
let i = 2;
while (components[i] && components[i] !== "d") {
let expr = (i === 2 ? "/" : "-") + components[i];
core.print(`!!!!! path += ${hexEncode(expr)}\n`, true);
path += expr;
i++;
}
const resolveFrom = combinePaths(currentDirectory, `__lib_node_modules_lookup_${libFileName}__.ts`);
core.print(`pathForLibFile(${libFileName}): \n defaultLibraryPath = ${defaultLibraryPath}\n resolveFrom = ${resolveFrom}\n path = ${path}\n`, true);
const localOverrideModuleResult = resolveModuleName("@typescript/lib-" + path, resolveFrom, { moduleResolution: 2 /* Node10 */ }, host, moduleResolutionCache);
if (localOverrideModuleResult == null ? void 0 : localOverrideModuleResult.resolvedModule) {
return localOverrideModuleResult.resolvedModule.resolvedFileName;
}
return combinePaths(defaultLibraryPath, libFileName);
}The while loop is producing wrong results on riscv64:
before call processRootFile: lib.deno.ns.d.ts entering pathForLibFile(lib.deno.ns.d.ts):
!!!!! path = deno, components = lib,deno,ns,d,ts !!!!! path += 0060006e0073 !!!!! path += 000b0064 !!!!! path += 000b00740073 pathForLibFile(lib.deno.ns.d.ts):
defaultLibraryPath = asset:///lib.esnext.d.ts
resolveFrom = cache:///__lib_node_modules_lookup_lib.deno.ns.d.ts__.ts
path = deno`ns
d
ts resolveModuleName(@typescript/lib-deno`ns
d
ts, cache:///__lib_node_modules_lookup_lib.deno.ns.d.ts__.ts, [object Object], [object Object], undefined, undefined, undefined)
The log doesn't look nice. There are some extra characters:
for "ns", there is an extra U+0060(`) before it
for "d" and "ts", there is an extra U+000B(Line Tabulation) before it
(The loop actually shouldn't reach here, the correct result is "deno/ns")It looks like a V8 bug.
By explicitly using char codes I can workaround this bug:
// while (components[i] && components[i] !== "d") {
while (components[i] && components[i].charCodeAt(0) !== 100) {
// let expr = (i === 2 ? "/" : "-") + components[i];
let expr;
if (i === 2)
expr = String.fromCharCode(47) + components[i];
else
expr = String.fromCharCode(45) + components[i];But there are other places that have bugs about path manipulation operations. So only fixing this one place can't let that error go away.
Any suggestions and helps will be well appreciated!
hack3ric
tuler
shodan8192
I've successfully built Deno (1.32.3, 1.32.4 in progress) in qemu-user and run on HiFive Unmatched on Arch Linux riscv64.
Some tweaks I did:
clang,lld,gnandninjato manually build V8.NO_PRINT_GN_ARGS=1. GN somehow segfaults when printing arguments, but it is trivial for now and doesn't affect generating build files.v8_enable_shared_ro_heap. This is intentially disabled, but we need to wait for pointer compression to meet rusty_v8's requirement and disable it.ringwith felixonmars/ring to provide C fallback for platforms without assembly crypto implementation.Environment variables exported:
Build script for Arch Linux can be found in https://github.com/felixonmars/archriscv-packages/pull/2510. Patch Arch Linux's official PKGBUILD and build it:
Caveats
Note that current build runs TypeScript scripts normally, but in REPL errors will appear (while not affecting basic auto completion functionality):
This is triggered only by TypeScript LSP's
getDiagnosticsrequest. Other LSP requests with specifiers containing$deno$repl.tsseem to not fail. I'm yet to find out why.