search

denoland / deno

A modern runtime for JavaScript and TypeScript.
https://deno.com
MIT License
98.1k stars 5.4k forks source link

Missing type definition related to resizable ArrayBuffer. #19191

Closed dojyorin closed 1 day ago

dojyorin commented 1 year ago

The resizable ArrayBuffer seems to be re-enabled, but the type definition are missing. Is it the effect of being temporarily disabled...?

Environment

deno-rab-issue-1 deno-rab-issue-2 deno-rab-issue-3 deno-rab-issue-4

indrajitbnikam commented 1 year ago

Can I work on this issue? Also, @dsherret Can you guide me a bit since this is my first OSS contribution?

indrajitbnikam commented 1 year ago

How can I generate types?

petamoriken commented 1 year ago

@indrajitbnikam Maybe you can try to contribute to upstream. There are d.ts files in /src/lib directory. Deno's /cli/tsc/dts directory is copied from TypeScript.

dsherret commented 1 year ago

Ah, right. I forgot this would probably be updating TypeScript.

indrajitbnikam commented 1 year ago

Yes, I'm working on it.

indrajitbnikam commented 1 year ago

I've created an Issue and have also raised the PR for the same in upstream. Can somebody please check and let me know what more needs to be done?

indrajitbnikam commented 1 year ago

Hi, Can someone tell me what I need to put here in Configuration Check section for this issue? I did not change it while creating the issue.

image

Sorry, This is my first contribution so a lot of things are new for me.

petamoriken commented 6 months ago

Upstream: https://github.com/microsoft/TypeScript/pull/58573

petamoriken commented 6 days ago

Tracking in #26950

dsherret commented 1 day ago

Yeah, let's track this in https://github.com/denoland/deno/issues/26950