handle signal 0 on windows as well on process.kill

denoland / deno

A modern runtime for JavaScript and TypeScript.

https://deno.com

MIT License

93.9k stars 5.22k forks source link

handle signal 0 on windows as well on process.kill #23938

Open sigmaSd opened 3 months ago

sigmaSd commented 3 months ago

linux fixed in https://github.com/denoland/deno/pull/23473

I thought in windows we should just ignore the signal, but I checked now libuv and they do special case this

https://github.com/libuv/libuv/blob/d9d207774ea1f734310982300e55dd64b3f5682b/src/win/process.c#L1191

Side note: is it a deliberate choice that process.kill now requires --allow-run permission ? isn't too much ? @littledivy

littledivy commented 3 months ago

is it a deliberate choice that process.kill now requires --allow-run permission

This has always been the case as far as I can see in git blame.

--allow-run is currently the most appropriate permission flag for it since its related to controlling processes. It is a little out of place and could be its own --allow-kill (maybe --allow-unrun :sweat_smile:)