search

denoland / deno

A modern runtime for JavaScript and TypeScript.
https://deno.com
MIT License
93.4k stars 5.18k forks source link

Bug: Panic when running `moment`'s test suite #24408

Open marvinhagemeister opened 4 days ago

marvinhagemeister commented 4 days ago 
Platform: macos aarch64
Version: 1.44.4
Args: ["/Users/marvinh/dev/denoland/deno/target/debug/deno", "run", "--unstable-ffi", "--unstable-fs", "--unstable-webgpu", "--node-modules-dir", "-A", "/Users/marvinh/dev/oss/moment/node_modules/node-qunit/lib/child.js", "grunt", "/Users/marvinh/dev/oss/moment/node_modules/grunt/bin/grunt", "test", ...]

thread 'main' panicked at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/deno_core-0.292.0/ops.rs:54:5:
op op_node_ipc_write was not marked as #[op2(reentrant)], but re-entrantly invoked op op_apply_source_map
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Steps to reproduce

  1. Clone https://github.com/moment/moment
  2. Run npm i
  3. Run DENO_FUTURE=1 deno task test

Version: Deno 1.44.4 (git 496ea5903 )

J053Fabi0 commented 4 days ago

I don't know if it's relevant, but moment is not working since Deno 1.44.3.

1.44.2: image

1.44.3 and 1.44.4: image

marvinhagemeister commented 4 days ago

@J053Fabi0 It sounds like you're not getting the same panic error as described in the original issue here. Based on that it seems likely that this is a different issue, even if it also occurs with moment. Can you file a separate issue for that? That way we can much more effectively triage issues and work on them in parallel.