denoland / deno

A modern runtime for JavaScript and TypeScript.
https://deno.com
MIT License
97.43k stars 5.37k forks source link

Running "create-next-app" without permissions flags causes terminal to crash #25185

Open thisisjofrank opened 2 months ago

thisisjofrank commented 2 months ago

Version: Deno 1.46.0

If I try to run

deno run npm:create-next-app@latest my-next-app

and walk through the permissions prompts, after the final prompt the program hangs and crashes the terminal.

Note: deno run -A npm:create-next-app@latest my-next-app runs absolutely fine.

yazan-abdalrahman commented 2 months ago

@thisisjofrank @littledivy @bartlomieju @dsherret It works, and it asks for a lot of permission, so I don't think it an issue, and I assume no one will try to use it without -A.

image image

thisisjofrank commented 2 months ago

Doesn't work on my machine... Once I get through all the permissions prompts it hangs on the 'would you like to use TypeScript prompt and then the entire terminal crashes

In both bash and powershell on windows.

yazan-abdalrahman commented 2 months ago

Doesn't work on my machine... Once I get through all the permissions prompts it hangs on the 'would you like to use TypeScript prompt and then the entire terminal crashes

In both bash and powershell on windows.

For me, I can't reproduce it.

@dsherret @bartlomieju

marvinhagemeister commented 2 months ago

Can reproduce it on my windows machine in powershell.

yazan-abdalrahman commented 2 months ago

Can reproduce it on my windows machine in powershell.

@marvinhagemeister If you put one of the permission prompts n, it will crash, but if you put all permissions y, it will operate properly.

 how many prompts it will accept? since it supplies too many prompts.

I believe this case not applicable, it will not actually issue,

marvinhagemeister commented 2 months ago

I ran into the scenario where I accepted all prompts individually, but was stuck at the Would you like to use TypeScript prompt. I couldn't even move the cursor between the choices and the whole process was unresponsive to any keyboard input. I cannot reliably reproduce it though. Seems to sometimes happen, sometimes not.

yazan-abdalrahman commented 2 months ago

https://github.com/user-attachments/assets/14783fd6-2a62-4b53-82e9-a503abb30bfb

@marvinhagemeister

yazan-abdalrahman commented 2 months ago

https://github.com/user-attachments/assets/4d43728c-29dd-4d5a-a290-e3c4b476609e

yazan-abdalrahman commented 2 months ago

image

marvinhagemeister commented 2 months ago

Sounds like this is a tricky one to reproduce reliably, or the exact reproduction steps haven't been found yet.

thisisjofrank commented 2 months ago

Even if I Y or A all permission as they prompt it still crashes at "would you like to use typescript" and the cursor can't move between, as @marvinhagemeister experienced.

thisisjofrank commented 2 months ago

Happy to jump on a call and show you if it's helpful?

littledivy commented 4 weeks ago

Reproducible on macOS too