denoland / deno

A modern runtime for JavaScript and TypeScript.
https://deno.com
MIT License
96.08k stars 5.31k forks source link

Turbo/ core pack support #26293

Open brrock opened 13 hours ago

brrock commented 13 hours ago

I am liking Deno but I have one thing before I can switch, the ability to work with Turbo and put Deno as the package manager in my existing package.json

marvinhagemeister commented 11 hours ago

What error are you getting? Can you share it?

brrock commented 11 hours ago

Thanks for your response I was wondering if it worked. In package.json in the package manager section ( e.g where you would be pnpm)

brrock commented 11 hours ago

And also for create next or whatever app why does that still run npm install instead deno install which is faster

marvinhagemeister commented 10 hours ago

And also for create next or whatever app why does that still run npm install instead deno install which is faster

Looks like the create-next-app isn't aware that Deno exists: https://github.com/vercel/next.js/blob/9a1cd356dbafbfcf23d1b9ec05f772f766d05580/packages/create-next-app/helpers/get-pkg-manager.ts#L3-L18

export function getPkgManager(): PackageManager {
  const userAgent = process.env.npm_config_user_agent || ''

  if (userAgent.startsWith('yarn')) {
    return 'yarn'
  }

  if (userAgent.startsWith('pnpm')) {
    return 'pnpm'
  }

  if (userAgent.startsWith('bun')) {
    return 'bun'
  }

  return 'npm'
}
brrock commented 10 hours ago

I'm making a PR for next then

brrock commented 10 hours ago

What about core pack and deno