denoland / deno

A modern runtime for JavaScript and TypeScript.
https://deno.com
MIT License
98.01k stars 5.39k forks source link

`deno compile --code-cache-path` #26980

Open felipecrs opened 21 hours ago

felipecrs commented 21 hours ago

With the new code cache, compiled programs would end up writing to ~/.cache/deno. This may not be desirable. The program may have its own cache directory for example. Also, it would end up creating this directory in systems where Deno isn't even installed, which could lead to end-user confusion. End-users may not even know what is Deno.

dsherret commented 21 hours ago

One issue with this is it's hard to configure. Maybe the code cache directory should just not have deno in the name.

dsherret commented 21 hours ago

I just checked and the code cache is written to the temp directory with the application name and not to ~/.cache/deno. https://github.com/denoland/deno/pull/26977 will make this more clear in the future

felipecrs commented 21 hours ago

Oh. What is this then?

❯ deno clean

❯ ./pkgx-cc --sync

❯ ls -la /home/felipecrs/.cache/deno
total 88
drwxr-xr-x  2 felipecrs felipecrs  4096 Nov 21 15:00 .
drwxr-xr-x 29 felipecrs felipecrs  4096 Nov 21 15:00 ..
-rw-r--r--  1 felipecrs felipecrs  4096 Nov 21 15:00 node_analysis_cache_v2
-rw-r--r--  1 felipecrs felipecrs 32768 Nov 21 15:00 node_analysis_cache_v2-shm
-rw-r--r--  1 felipecrs felipecrs 41232 Nov 21 15:00 node_analysis_cache_v2-wal
felipecrs commented 21 hours ago

I see. That's something else. I found the actual cc here:

❯ ls -lah /tmp/deno-compile-*
-rw-r--r-- 1 felipecrs felipecrs 1.8M Nov 21 14:12 /tmp/deno-compile-pkgx-cc.cache
felipecrs commented 21 hours ago

Oh. What is this then?

Those files are created even when using Deno 2.0.6, thus it's indeed unrelated.