denoland / deno

A modern runtime for JavaScript and TypeScript.
https://deno.com
MIT License
97.23k stars 5.37k forks source link

Add timeouts to web platform tests #9460

Closed caspervonb closed 1 month ago

caspervonb commented 3 years ago

Tried running a wpt update and it eventually got stuck in fetch.

/fetch/api/abort/general.any.html

test Request objects have a signal property ... failed
test Signal state is cloned ... failed
test Clone aborts with original controller ... failed
test Aborting rejects with AbortError ... failed
test Aborting rejects with AbortError - no-cors ... failed
test TypeError from request constructor takes priority - RequestInit's window is not null ... ok
test TypeError from request constructor takes priority - Input URL is not valid ... failed
test TypeError from request constructor takes priority - Input URL has credentials ... ok
test TypeError from request constructor takes priority - RequestInit's mode is navigate ... ok
test TypeError from request constructor takes priority - RequestInit's referrer is invalid ... ok
test TypeError from request constructor takes priority - RequestInit's method is invalid ... ok
test TypeError from request constructor takes priority - RequestInit's method is forbidden ... ok
test TypeError from request constructor takes priority - RequestInit's mode is no-cors and method is not simple ... ok
test TypeError from request constructor takes priority - RequestInit's cache mode is only-if-cached and mode is not same-origin ... ok
test TypeError from request constructor takes priority - Request with cache mode: only-if-cached and fetch mode cors ... ok
test TypeError from request constructor takes priority - Request with cache mode: only-if-cached and fetch mode no-cors ... ok
test TypeError from request constructor takes priority - Bad referrerPolicy init parameter value ... ok
test TypeError from request constructor takes priority - Bad mode init parameter value ... ok
test TypeError from request constructor takes priority - Bad credentials init parameter value ... ok
test TypeError from request constructor takes priority - Bad cache init parameter value ... ok
test TypeError from request constructor takes priority - Bad redirect init parameter value ... ok
test Signal on request object ... failed
test Signal on request object created from request object ... failed
test Signal on request object created from request object, with signal on second request ... failed
test Signal on request object created from request object, with signal on second request overriding another ... failed
test Signal retained after unrelated properties are overridden by fetch ... failed
test Signal removed by setting to null ... ok
test Already aborted signal rejects immediately ... failed
test Request is still 'used' if signal is aborted before fetching ... ok
test response.arrayBuffer() rejects if already aborted ... failed
test response.blob() rejects if already aborted ... failed
test response.formData() rejects if already aborted ... failed
test response.json() rejects if already aborted ... failed
test response.text() rejects if already aborted ... failed
test Already aborted signal does not make request ... failed
test Already aborted signal can be used for many fetches ... failed
test Signal can be used to abort other fetches, even if another fetch succeeded before aborting ... failed
test Underlying connection is closed when aborting after receiving response ... failed
test Underlying connection is closed when aborting after receiving response - no-cors ... failed

I gave up after around 20 minutes and killed the process. Adding a reasonable default timeout to each test would be good (there's also the meta comment to consider, which should override it).

lucacasonato commented 3 years ago

On my backburner. Will address soon.

lucacasonato commented 1 month ago

We have this now