search

denoland / deno

A modern runtime for JavaScript and TypeScript.
https://deno.com
MIT License
94.66k stars 5.25k forks source link

Upgrade to TypeScript 3.1 #969

Closed ry closed 5 years ago

ry commented 5 years ago

ts-simple-ast does not yet support it, but will soon.

cc @dsherret @kitsonk

dsherret commented 5 years ago

@ry I'm doing a release probably tonight to support 3.1.x. Will comment back here when done.

Side note: In TS 3.1.1 some of my kind of large mapped w/ conditional types were resolving to any in my declaration file build script and I was going to spend time investigating, but seems like the TypeScript team fixed that in 3.1.3, which was released about an hour ago :)

kitsonk commented 5 years ago

Cool @dsherret, once you got it there, we can look at 3.1.3 for Deno. I don't expect any impacts on Deno from 3.0 to 3.1 but sometimes TypeScript can surprise you.

dsherret commented 5 years ago

I released 17.0.0 which is tested against a few versions of the compiler including 3.1.1 and 3.1.3. I also opened an issue on my repo to run a cron job on the CI that will test ts-simple-ast against the latest TypeScript RC package. That will help me stay on top of new compiler API releases and be aware if there are any problems before an actual release occurs.

I believe it should work fine and yarn should not pull in a separate version of typescript, but let me know if you run into any problems. I was going to test with deno, but it's building on a linux vm right now and taking a bit of time (I got this error building on windows and then gave up).

By the way, I highly recommend storing lib.deno_runtime.d.ts in source control as well. That way you will more noticeably see all the changes and if anything goes wrong you will notice the problem before publishing (like my experience with the ts compiler resolving some types to any in v3.1.1). It will also help catch types you meant to mark with internal.

ry commented 5 years ago

I released 17.0.0

Great!

By the way, I highly recommend storing lib.deno_runtime.d.ts in source control as well

Hmm I'd rather not... but maybe. I think lib.deno_runtime.d.ts gets extensively tested in our tests - so I'm hoping if it gets malformed, or whatever, that something will break. That said, let's see what happens over the next week.