denoland / deno_ast

Source text parsing, lexing, and AST related functionality for Deno
https://crates.io/crates/deno_ast
MIT License
156 stars 46 forks source link

feat: swc_ecma_parser 0.137.5 #151

Closed sido378 closed 1 year ago

sido378 commented 1 year ago

Hi, Hope it's okay to open a PR like this, since https://github.com/denoland/deno_ast/pull/148 has been open/approved for about a month now, and 0.137.5 of swc_ecma_parser has been released in the meantime.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

dsherret commented 1 year ago

We can't upgrade because we're blocked by https://github.com/swc-project/swc/issues/7621 (https://github.com/swc-project/swc/pull/7692). I've been working on #148, but haven't had much time to fix the swc issue.

sido378 commented 1 year ago

Oh sorry, I was not aware of that. Please excuse the noise and feel free to close this PR.

dsherret commented 1 year ago

It was my bad for not updating the PR with the status. Usually an swc upgrade is a big task because it needs to be tested with all the downstream Deno crates and that often requires a few code changes. In this case, I reverted the PR in swc that was causing some trouble so that we can proceed with the upgrade.