search

denoland / deno_ast

Source text parsing, lexing, and AST related functionality for Deno
https://crates.io/crates/deno_ast
MIT License
144 stars 43 forks source link

Update version of SWC #220

Closed alshdavid closed 4 months ago

alshdavid commented 4 months ago

Updated the version of SWC.

Not sure how to test this change, I ran:

cargo build
cargo test

I'm not sure how to consume this from Deno CLI locally for testing

CLAassistant commented 4 months ago

CLA assistant check
All committers have signed the CLA.

dsherret commented 4 months ago

Updating swc takes about a days worth of work because we need to test this in all dependent crates and make certain updates. Are there any specific fixes in swc that you need? We'll probalby do an swc upgrade again once https://github.com/swc-project/swc/pull/8736 lands (we do an swc upgrade about once a month)

alshdavid commented 4 months ago

Updating swc takes about a days worth of work because we need to test this in all dependent crates and make certain updates. Are there any specific fixes in swc that you need? We'll probalby do an swc upgrade again once swc-project/swc#8736 lands (we do an swc upgrade about once a month)

Hey, thanks for reviewing my change. My motivation for bumping swc is that my main project already uses a newer version of swc and consuming deno_ast causes a versioning conflict that Cargo cannot resolve.

That said I have managed to isolate Deno (and its dependencies) from my main application so this is no longer a concern and there is no urgency to merge this PR from my end.