search

denoland / deno_ast

Source text parsing, lexing, and AST related functionality for Deno
https://crates.io/crates/deno_ast
MIT License
155 stars 46 forks source link

Upgrade swc after resolution of swc issues #76

Closed dsherret closed 2 years ago

dsherret commented 2 years ago

The new OptCall in swc makes a lot of our code more error prone. We will upgrade once this issue is resolved or alternatively change dprint-swc-ecma-ast-view to combine these two nodes together in the wrapper: https://github.com/swc-project/swc/issues/4010

dsherret commented 2 years ago

Blocked on https://github.com/swc-project/swc/issues/4050

dsherret commented 2 years ago

Another swc issue: https://github.com/swc-project/swc/issues/4067

After thinking about this one, the TS compiler itself can't figure this out in 4.6, but it can in 4.7 (unreleased). Also, it parses in JS. For that reason I'm going to proceed with the upgrade.