fix(cli): bug when a relative path ends with double dot

denoland / deno_bindgen

Write high-level Deno FFI libraries in Rust.

MIT License

274 stars 28 forks source link

fix(cli): bug when a relative path ends with double dot #116

Closed ansemb closed 1 year ago

ansemb commented 1 year ago

Fixes a bug when using the cli from within a packages/x directory in a cargo workspace.

findRelativeTarget() can return ../.. which is added (not joined) with ../target, hence creating a quadruple dot path. ../..../target, which results in an error when trying to run.

error: Uncaught (in promise) CacheError: /[...]/repo_root/packages/<package-name>/..../target/debug/lib<package-name>.so is not valid.
    throw new CacheError(`${path} is not valid.`);

CLAassistant commented 1 year ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

adrian seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}