search

denoland / deno_bindgen

Write high-level Deno FFI libraries in Rust.
MIT License
274 stars 28 forks source link

fix: breaking ffi changes #118

Closed load1n9 closed 1 year ago

load1n9 commented 1 year ago

Deno pointers are no longer bigints, these changes fix the breaking generated code

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

lino-levan commented 1 year ago

Wait hold on, is this a duplicate of #117? Either way, one of these two should be merged.

kt3k commented 1 year ago

@littledivy PTAL

zifeo commented 1 year ago

@load1n9 Maybe have a look at open PR to consolidate efforts for the next time :)

lino-levan commented 1 year ago

Still waiting on this to get merged... not sure who should do that?

kt3k commented 1 year ago

ref: https://github.com/denoland/deno/pull/16889

kt3k commented 1 year ago

@littledivy Do you think the current main is ready enough to be released? If so, I'll try to cut 0.8.0

kt3k commented 1 year ago

Looks like deno_bindgen --release=path command isn't working now (probably because of plug upgrade)? I'm trying to fix it in #121.