feat: decoding percent-encoding source string in `Error.stack`

Hajime-san commented 4 months ago

resolves https://github.com/denoland/deno_core/issues/757

Note

[x] when deno_core crate bumped to deno, the test will fail without fixing the output https://github.com/denoland/deno/blob/2024c974b613f94f31559a1b32e2d747c2083e91/tests/integration/test_tests.rs#L96
[x] when deno_core crate bumped to deno, the issue will resolve https://github.com/denoland/deno/issues/18983

CLAassistant commented 4 months ago

All committers have signed the CLA.

bartlomieju commented 2 months ago

Sorry for a slow turn-around @Hajime-san. This looks good to me, but it would be great if a test case could be added. It can be as simple as a unit test for format_file_name function.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.74%. Comparing base (0c7f83e) to head (2f2c401). Report is 71 commits behind head on main.

Files	Patch %	Lines
core/error.rs	96.29%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #759 +/- ## ========================================== + Coverage 81.43% 81.74% +0.30% ========================================== Files 97 98 +1 Lines 23877 24462 +585 ========================================== + Hits 19445 19997 +552 - Misses 4432 4465 +33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

denoland / deno_core

feat: decoding percent-encoding source string in `Error.stack` #759

Note

Codecov Report