denoland / deno_core

The core engine at the heart of Deno
MIT License
233 stars 76 forks source link

Add a v8::Global variant of magic::Value #796

Closed rscarson closed 2 weeks ago

rscarson commented 2 weeks ago

Allows the direct deserialization of globals across serde boundaries, which will be exceptionally useful in downstream projects

As discussed with @bartlomieju

rscarson commented 2 weeks ago

LGTM aside from the doc comment.

It would also be good to add a simple test to serde_v8/tests/magic.rs, if you don't mind.

Done!