denoland / deno_core

The core engine at the heart of Deno
MIT License
233 stars 76 forks source link

bit-vec dependency version should be specified #797

Closed AceRogue closed 1 week ago

AceRogue commented 1 week ago

Now the version is specified with "0", and current newest is 0.7.0. But bit-set use 0.6.3. I get compile error if I do not specify the version in cargo.lock.

turingbuilder commented 1 week ago

I get the same error trying to use `deno_core = "0.291".

The specific error is:

error[E0308]: mismatched types
   --> /.../.cargo/registry/src/index.crates.io-6f17d22bba15001f/deno_core-0.291.0/arena/raw_arena.rs:290:43
    |
290 |         for alloc in BitSet::from_bit_vec(vacant).into_iter() {
    |                      -------------------- ^^^^^^ expected `bit_vec::BitVec`, found `BitVec`
    |                      |
    |                      arguments to this function are incorrect
    |
    = note: `BitVec` and `bit_vec::BitVec` have similar names, but are actually distinct types
note: `BitVec` is defined in crate `bit_vec`
   --> /.../.cargo/registry/src/index.crates.io-6f17d22bba15001f/bit-vec-0.7.0/src/lib.rs:245:1
    |
245 | pub struct BitVec<B = u32> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^
note: `bit_vec::BitVec` is defined in crate `bit_vec`
   --> /../.cargo/registry/src/index.crates.io-6f17d22bba15001f/bit-vec-0.6.3/src/lib.rs:212:1
    |
212 | pub struct BitVec<B=u32> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^
    = note: perhaps two different versions of crate `bit_vec` are being used?
note: associated function defined here
   --> /.../.cargo/registry/src/index.crates.io-6f17d22bba15001f/bit-set-0.5.3/src/lib.rs:238:12
    |
238 |     pub fn from_bit_vec(bit_vec: BitVec) -> Self {
    |            ^^^^^^^^^^^^

And here is the partial output of cargo tree:

.
.
.
├── deno_core v0.291.0
│   ├── anyhow v1.0.75
│   ├── bincode v1.3.3
│   │   └── serde v1.0.203
│   ├── bit-set v0.5.3
│   │   └── bit-vec v0.6.3
│   ├── bit-vec v0.7.0
.
.
.
Xuanwo commented 1 week ago

Hi, is it possible to make a quick release for this change? Our CI tests are broken for the same problem.

Yohe-Am commented 1 week ago

+1

miguelski commented 1 week ago

please i am waiting the release of this fix it is impossible to build our project since past week

bartlomieju commented 1 week ago

We will cut a release of deno_core after fixing CI today.