Open littledivy opened 6 days ago
Attention: Patch coverage is 95.63636%
with 12 lines
in your changes missing coverage. Please review.
Project coverage is 81.89%. Comparing base (
0c7f83e
) to head (19e91c6
). Report is 50 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
testing/checkin/runner/ops.rs | 82.22% | 8 Missing :warning: |
core/extensions.rs | 87.50% | 1 Missing :warning: |
ops/op2/config.rs | 90.90% | 1 Missing :warning: |
ops/op2/dispatch_slow.rs | 85.71% | 1 Missing :warning: |
ops/op2/object_wrap.rs | 98.33% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Have you done any performance benchmarks?
$ target/release/dcore bench.js
JS x(): 87ms
Rust x(): 285ms
JS create: 904ms
Rust create: 1706ms
So...not great atm, working on it. Object::wrap
and Object::unwrap
can take Isolate instead of HandleScopes so we can avoid creating and dropping scope in most cases - which is 30% of the overhead.
Object wrap for Cppgc-backed objects
#[op2]
will generate the glue code declarations forimpl
blocks to create JS objects in Rust using the op2 infra.Currently supported bindings:
static methods
Planned support:
Future:
Example: